feat(table): read selectable prop from each row by default #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimjaej - Hi there! Thanks for adding a PR in Sage. Could you provide a bit more information in the Conversation portion of the PR so that we may better understand and review your work so you can merge? Specifically, how do we test your change in Storybook, are there any visuals you can provide us a before/after, and does this change impact |
ju-Skinner
approved these changes
Dec 6, 2022
teenwolfblitzer
approved these changes
Dec 7, 2022
| @@ -278,7 +278,7 @@ export const Table = ({ | |||
| cells={cells} | |||
| schema={schema} | |||
| selected={selfSelectedRows === SELECTION_TYPES.ALL || selfSelectedRows.includes(rowId)} | |||
| selectable={selectable} | |||
| selectable={!!(row.selectable || selectable)} | |||
There was a problem hiding this comment.
Curious about the double negation here. Is it the case that one or both of row.selectable and selectable aren't set as booleans? I'm basing this all off of the propTypes defs enforcement; unsure of what we're actually finding in-app.
ju-Skinner
force-pushed
the
develop
branch
11 times, most recently
from
b5f45fa
to
d0f2ff2
Compare
ju-Skinner
force-pushed
the
develop
branch
6 times, most recently
from
a0cb960
to
041b58b
Compare
ju-Skinner
force-pushed
the
develop
branch
4 times, most recently
from
11dde9c
to
48f6933
Compare
ju-Skinner
force-pushed
the
develop
branch
6 times, most recently
from
81a9318
to
da9b7c3
Compare
ju-Skinner
force-pushed
the
develop
branch
10 times, most recently
from
7caaef2
to
3359401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read selectable prop from the row by default
Screenshots
Testing in
sage-libTesting in
kajabi-productsRelated
https://kajabi.atlassian.net/browse/MAN-2626